child_process: treat ipc length header as unsigned uint32 #61344
+44
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
child_process
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61344 +/- ##
=======================================
Coverage 88.52% 88.53%
=======================================
Files 704 704
Lines 208739 208739
Branches 40280 40277 -3
=======================================
+ Hits 184787 184802 +15
+ Misses 15969 15932 -37
- Partials 7983 8005 +22
🚀 New features to boost your workflow:
|
avivkeller
approved these changes
Jan 11, 2026
avivkeller
added
author ready
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
avivkeller
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/61344 ✔ Done loading data for nodejs/node/pull/61344 ----------------------------------- PR info ------------------------------------ Title child_process: treat ipc length header as unsigned uint32 (#61344) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch islandryu:61312 -> nodejs:main Labels child_process, author ready, needs-ci Commits 1 - child_process: treat ipc length header as unsigned uint32 Committers 1 - islandryu <shimaryuhei@gmail.com> PR-URL: https://github.com/nodejs/node/pull/61344 Fixes: https://github.com/nodejs/node/issues/61312 Reviewed-By: Aviv Keller <me@aviv.sh> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/61344 Fixes: https://github.com/nodejs/node/issues/61312 Reviewed-By: Aviv Keller <me@aviv.sh> -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 11 Jan 2026 12:56:43 GMT ✔ Approvals: 1 ✔ - Aviv Keller (@avivkeller): https://github.com/nodejs/node/pull/61344#pullrequestreview-3647772955 ✘ This PR needs to wait 60 more hours to land (or 0 minutes if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2026-01-14T02:39:35Z: https://ci.nodejs.org/job/node-test-pull-request/70798/ - Querying data for job/node-test-pull-request/70798/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/21052084247 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #61312